feat(match2): store further date props in game extradata #5338
+31
−542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rathoz
reviewed
Jan 16, 2025
Rathoz
reviewed
Jan 16, 2025
Rathoz
reviewed
Jan 16, 2025
Co-authored-by: Rikard Blixt <[email protected]>
|
needs retesting, will do later today |
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
dateexact,timestamp,timezoneIdandtimezoneOffset) in extradata so they are available e.g. when displaying a gamesummary.remark
i plan to clean up sc2 and wc input processing (ffa parts) a bit in the upcoming days (after this pr gets merged)
the idea is to be able to use standardProcessFfaMaps eventually even on those 3 wikis
How did you test this change?
dev